Client V3.51 & V3.82 C++ Sources

locobans · Post by **locobans** » Thu Apr 20, 2006 11:22 pm

Drazz wrote:
locobans wrote:
Drajwer wrote: and the sprites bug... tower shield is on char but is not drawed (tower, merien shield) and some of colored items (normal legs is visible on ground but black legs arent). Strange...
LMAO! now that I know...I had a BLACK wand...and wasn't showing on floor...ground...black colour related? :unsure:
Look for
Code: Select all
	else 
    	{	switch (sItemSprite) {
      case 1:
      case 2:
      case 3:
      case 15: m_pSprite[DEF_SPRID_ITEMGROUND_PIVOTPOINT + sItemSprite]->PutSpriteRGB(ix, iy, sItemSpriteFrame, m_wWR[cItemColor] -m_wR[0], m_wWG[cItemColor] -m_wG[0], m_wWB[cItemColor] -m_wB[0], dwTime); break;
      //default: m_pSprite[DEF_SPRID_ITEMGROUND_PIVOTPOINT + sItemSprite]->PutSpriteRGB(ix, iy, sItemSpriteFrame, m_wR[cItemColor] -m_wR[0], m_wG[cItemColor] -m_wG[0], m_wB[cItemColor] -m_wB[0], dwTime); break;
And Remove '//' before default:

PD: Maybe better remove switch?

Thank you.

juggalo2 · Post by **juggalo2** » Fri Apr 21, 2006 12:20 am

if u can conferim its 300 stats then i think i knwo where it cxhanged from skimming thro i dont have time to check but ill chck poost latter on to see

diuuude · Post by **diuuude** » Fri Apr 21, 2006 12:30 am

pffff....

DrawDialogBox_LevelUpSettings
DlgBoxClick_LevelUpSettings

Did you try anything before asking stupid questions ?

€M4NU€L · Post by **€M4NU€L** » Fri Apr 21, 2006 8:22 am

diuuude wrote: pffff....

DrawDialogBox_LevelUpSettings
DlgBoxClick_LevelUpSettings

Did you try anything before asking stupid questions ?

I see that you are in bad mod today ...

€M4NU€L · Post by **€M4NU€L** » Fri Apr 21, 2006 9:05 am

Drazz wrote:
locobans wrote:
Drajwer wrote: and the sprites bug... tower shield is on char but is not drawed (tower, merien shield) and some of colored items (normal legs is visible on ground but black legs arent). Strange...
LMAO! now that I know...I had a BLACK wand...and wasn't showing on floor...ground...black colour related? :unsure:
Look for
Code: Select all
	else 
    	{	switch (sItemSprite) {
      case 1:
      case 2:
      case 3:
      case 15: m_pSprite[DEF_SPRID_ITEMGROUND_PIVOTPOINT + sItemSprite]->PutSpriteRGB(ix, iy, sItemSpriteFrame, m_wWR[cItemColor] -m_wR[0], m_wWG[cItemColor] -m_wG[0], m_wWB[cItemColor] -m_wB[0], dwTime); break;
      //default: m_pSprite[DEF_SPRID_ITEMGROUND_PIVOTPOINT + sItemSprite]->PutSpriteRGB(ix, iy, sItemSpriteFrame, m_wR[cItemColor] -m_wR[0], m_wG[cItemColor] -m_wG[0], m_wB[cItemColor] -m_wB[0], dwTime); break;
And Remove '//' before default:

PD: Maybe better remove switch?

so we delete the '//' before default and switch ??

Code: Select all

    	{	switch (sItemSprite) {

Jensen · Post by **Jensen** » Fri Apr 21, 2006 9:19 am

Drazz wrote:
locobans wrote:
Drajwer wrote: and the sprites bug... tower shield is on char but is not drawed (tower, merien shield) and some of colored items (normal legs is visible on ground but black legs arent). Strange...
LMAO! now that I know...I had a BLACK wand...and wasn't showing on floor...ground...black colour related? :unsure:
Look for
Code: Select all
	else 
    	{	switch (sItemSprite) {
      case 1:
      case 2:
      case 3:
      case 15: m_pSprite[DEF_SPRID_ITEMGROUND_PIVOTPOINT + sItemSprite]->PutSpriteRGB(ix, iy, sItemSpriteFrame, m_wWR[cItemColor] -m_wR[0], m_wWG[cItemColor] -m_wG[0], m_wWB[cItemColor] -m_wB[0], dwTime); break;
      //default: m_pSprite[DEF_SPRID_ITEMGROUND_PIVOTPOINT + sItemSprite]->PutSpriteRGB(ix, iy, sItemSpriteFrame, m_wR[cItemColor] -m_wR[0], m_wG[cItemColor] -m_wG[0], m_wB[cItemColor] -m_wB[0], dwTime); break;
And Remove '//' before default:

PD: Maybe better remove switch?

he was suggesting this

Code: Select all

else
    { m_pSprite[DEF_SPRID_ITEMGROUND_PIVOTPOINT + sItemSprite]->PutSpriteRGB(ix, iy, sItemSpriteFrame, m_wR[cItemColor] -m_wR[0], m_wG[cItemColor] -m_wG[0], m_wB[cItemColor] -m_wB[0], dwTime);

theres a little different code for some reason for 1,2,3, and 15 though so im leaving the switch in personally

€M4NU€L · Post by **€M4NU€L** » Fri Apr 21, 2006 10:51 am

Well ... all items that have different colour of their default colour won't show on the Floor

Shetar · Post by **Shetar** » Fri Apr 21, 2006 11:41 am

Yoo, I see you guys are bugfixing, good to hear! Any known heavily bugged features? I might be able to help

snoopy81 · Post by **snoopy81** » Fri Apr 21, 2006 2:25 pm

Uploaded v1.0.1.0

Last minute fix:
- Colored items (black) on ground.
(AS explaned above. I could never find this bug because this code had been rewritten for my server)

Known missing feature added:
- 3x3 for Wyverns, abaddon, Gate.
(Gates were not functionning with Siementec 3.51 client, so I designed a workaround server sided. As a result, I can't check it with this client)

Search, and add conditions...
BOOL CMapData::bGetIsLocateable(short sX, short sY)

Code: Select all

  if (m_pData[dX+1][dY+1].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 66) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 66) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 66) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 66) return FALSE;

  if (m_pData[dX+1][dY+1].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 73) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 73) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 73) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 73) return FALSE;

  if (m_pData[dX+1][dY+1].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 81) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 81) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 81) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 81) return FALSE;

  if (m_pData[dX+1][dY+1].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 91) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 91) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 91) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 91) return FALSE;

Search for: absY = abs(m_sPlayerY - m_sMCY); (4 times)
Below:

Code: Select all

if ((absX <= 1) && (absY <= 1))
    	{	wType = _iGetAttackType();
      m_cCommand = DEF_OBJECTATTACK;
      m_sCommX = m_sMCX;
      m_sCommY = m_sMCY;
    	}else...

Add else if ... at the 4 places.

Code: Select all

if ((absX <= 1) && (absY <= 1))
    	{	wType = _iGetAttackType();
      m_cCommand = DEF_OBJECTATTACK;
      m_sCommX = m_sMCX;
      m_sCommY = m_sMCY;
    	}else if ( (absX <= 2) && (absY <= 2) // strike on Big mobs & gate from a range
      	&& ((sObjectType == 66)||(sObjectType == 73)||(sObjectType == 81)||(sObjectType == 91)))
    	{	wType = _iGetAttackType();
      m_cCommand = DEF_OBJECTATTACK;
      m_sCommX = m_sMCX;
      m_sCommY = m_sMCY;
    	}else...

RageIlluminati · Post by **RageIlluminati** » Fri Apr 21, 2006 2:30 pm

gates function with 3.51 client fine... I have them working right with 3.51 client.. but I use original 3.51 server files as well...

€M4NU€L · Post by **€M4NU€L** » Fri Apr 21, 2006 2:31 pm

snoopy81 wrote: Uploaded v1.0.1.0

Last minute fix:
- Colored items (black) on ground.
(AS explaned above. I could never find this bug because this code had been rewritten for my server)

Known missing feature added:
- 3x3 for Wyverns, abaddon, Gate.
(Gates were not functionning with Siementec 3.51 client, so I designed a workaround server sided. As a result, I can't check it with this client)

Search, and add conditions...
BOOL CMapData::bGetIsLocateable(short sX, short sY)

Code: Select all

  if (m_pData[dX+1][dY+1].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 66) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 66) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 66) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 66) return FALSE;

  if (m_pData[dX+1][dY+1].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 73) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 73) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 73) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 73) return FALSE;

  if (m_pData[dX+1][dY+1].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 81) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 81) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 81) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 81) return FALSE;

  if (m_pData[dX+1][dY+1].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 91) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 91) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 91) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 91) return FALSE;

Search for: absY = abs(m_sPlayerY - m_sMCY); (4 times)
Below:

Code: Select all

if ((absX <= 1) && (absY <= 1))
    	{	wType = _iGetAttackType();
      m_cCommand = DEF_OBJECTATTACK;
      m_sCommX = m_sMCX;
      m_sCommY = m_sMCY;
    	}else...

Add else if ... at the 4 places.

Code: Select all

if ((absX <= 1) && (absY <= 1))
    	{	wType = _iGetAttackType();
      m_cCommand = DEF_OBJECTATTACK;
      m_sCommX = m_sMCX;
      m_sCommY = m_sMCY;
    	}else if ( (absX <= 2) && (absY <= 2) // strike on Big mobs & gate from a range
      	&& ((sObjectType == 66)||(sObjectType == 73)||(sObjectType == 81)||(sObjectType == 91)))
    	{	wType = _iGetAttackType();
      m_cCommand = DEF_OBJECTATTACK;
      m_sCommX = m_sMCX;
      m_sCommY = m_sMCY;
    	}else...

Snoopy ... there are all colours that doesn't show on ground not only black

Drajwer · Post by **Drajwer** » Fri Apr 21, 2006 2:54 pm

thanks for fixing colored items. now Shields M are still missing on character

.

snoopy81 · Post by **snoopy81** » Fri Apr 21, 2006 3:40 pm

now Shields M are still missing on character

I tought I fixed that long ago...
On character? F5 Diag or moving/running/hitting ..... ?

Drajwer · Post by **Drajwer** » Fri Apr 21, 2006 3:50 pm

on f5 character info its visible but on character (every event like running attacking etc.). i think some bows also arent drawed on char.

Cleroth · Post by **Cleroth** » Fri Apr 21, 2006 5:19 pm

snoopy81 wrote: Uploaded v1.0.1.0

Last minute fix:
- Colored items (black) on ground.
(AS explaned above. I could never find this bug because this code had been rewritten for my server)

Known missing feature added:
- 3x3 for Wyverns, abaddon, Gate.
(Gates were not functionning with Siementec 3.51 client, so I designed a workaround server sided. As a result, I can't check it with this client)

Search, and add conditions...
BOOL CMapData::bGetIsLocateable(short sX, short sY)

Code: Select all

  if (m_pData[dX+1][dY+1].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 66) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 66) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 66) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 66) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 66) return FALSE;

  if (m_pData[dX+1][dY+1].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 73) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 73) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 73) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 73) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 73) return FALSE;

  if (m_pData[dX+1][dY+1].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 81) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 81) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 81) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 81) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 81) return FALSE;

  if (m_pData[dX+1][dY+1].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX+1]  [dY].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX+1][dY-1].m_sOwnerType == 91) return FALSE;
  if (m_pData  [dX][dY+1].m_sOwnerType == 91) return FALSE;
  if (m_pData  [dX]  [dY].m_sOwnerType == 91) return FALSE;
  if (m_pData  [dX][dY-1].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX-1][dY+1].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX-1]  [dY].m_sOwnerType == 91) return FALSE;
  if (m_pData[dX-1][dY-1].m_sOwnerType == 91) return FALSE;

Search for: absY = abs(m_sPlayerY - m_sMCY); (4 times)
Below:

Code: Select all

if ((absX <= 1) && (absY <= 1))
    	{	wType = _iGetAttackType();
      m_cCommand = DEF_OBJECTATTACK;
      m_sCommX = m_sMCX;
      m_sCommY = m_sMCY;
    	}else...

Add else if ... at the 4 places.

Code: Select all

if ((absX <= 1) && (absY <= 1))
    	{	wType = _iGetAttackType();
      m_cCommand = DEF_OBJECTATTACK;
      m_sCommX = m_sMCX;
      m_sCommY = m_sMCY;
    	}else if ( (absX <= 2) && (absY <= 2) // strike on Big mobs & gate from a range
      	&& ((sObjectType == 66)||(sObjectType == 73)||(sObjectType == 81)||(sObjectType == 91)))
    	{	wType = _iGetAttackType();
      m_cCommand = DEF_OBJECTATTACK;
      m_sCommX = m_sMCX;
      m_sCommY = m_sMCY;
    	}else...

fvsjidahcasuiodhruewqoisancaskld!!!!!!!

I'm hiring you!