Buged Createitem function

[marleythe9]

well if u didnt know. but i found this bug.

if u do /createitem ItemName.

and the gm typed an item name that is bigger then 21 chars it crashes becouse the name dosnt suport more then 21 chars heres fix.

goto

Code: Select all

CGame::AdminOrder_CreateItem

and find

Code: Select all

	token = pStrTok->pGet();
	token = pStrTok->pGet();

then replace all whats under it tell

Code: Select all

pItem = new class CItem;

with this

Code: Select all

	// if the token is something it is an item name
	if (token != NULL) {
  if(strlen(token) > 21) return;
  ZeroMemory(cItemName, sizeof(cItemName));
  strcpy(cItemName, token);
	} // close if (token != NULL) {

	// if the 2nd token is true it is the item attribute
	ZeroMemory(cAttribute, sizeof(cAttribute));
	token = pStrTok->pGet();
	if (token != NULL) {
  if(strlen(token) > 256) return;
  ZeroMemory(cAttribute, sizeof(cAttribute));
  strcpy(cAttribute, token);
	} // close if (token != NULL) {

	// if the 3rd token is true it is the item value
	ZeroMemory(cValue, sizeof(cValue));
	iValue = 0;
	token = pStrTok->pGet();
	if (token != NULL) {
  if(strlen(token) > 256) return;
  ZeroMemory(cValue, sizeof(cValue));
  strcpy(cValue, token);
  iValue = atoi(cValue);
	} // close if (token != NULL) {

[bone-you]

OR, you can just do StringCbCopy(cItemName, 20, token); so it will never copy more than 20 characters.