[src]Ek Announcer only for Players

[cris002]

Simple
Find on game.cpp
Client Killed Handler
Scroll until u see something along the lines of

Code: Select all

	memcpy(KilledMessage1, cAttackerName, strlen(cAttackerName));
	strcat(KilledMessage1, " killed ");
	strcat(KilledMessage1, m_pClientList[iClientH]->m_cCharName);

Then Replace with

Code: Select all

  
	if (cAttackerType == DEF_OWNERTYPE_PLAYER) {
	memcpy(KilledMessage1, cAttackerName, strlen(cAttackerName));
	strcat(KilledMessage1, " killed ");
	strcat(KilledMessage1, m_pClientList[iClientH]->m_cCharName);
	}

Im pretty sure thats how it works, i might have missed something tell me if i have xD

And yes, i am only a basic coder...so dont keep calling me noob, cos i know i am

[Dax]

Simple
Find on game.cpp
Client Killed Handler
Scroll until u see something along the lines of

Code: Select all

	memcpy(KilledMessage1, cAttackerName, strlen(cAttackerName));
	strcat(KilledMessage1, " killed ");
	strcat(KilledMessage1, m_pClientList[iClientH]->m_cCharName);

Then Replace with

Code: Select all

  
	if (cAttackerType == DEF_OWNERTYPE_PLAYER) {
	memcpy(KilledMessage1, cAttackerName, strlen(cAttackerName));
	strcat(KilledMessage1, " killed ");
	strcat(KilledMessage1, m_pClientList[iClientH]->m_cCharName);
	}

Im pretty sure thats how it works, i might have missed something tell me if i have xD

And yes, i am only a basic coder...so dont keep calling me noob, cos i know i am

Looks good.

But whats wrong with using:

Code: Select all

if (cAttackerType == DEF_OWNERTYPE_PLAYER) wsprintf(KilledMessage1, "%s killed %s", cAttackerName, m_pClientList[iClientH]->m_cCharName);

[bone-you]

In all truth wsprintf is bad practice

Code: Select all

HRESULT StringCbPrintf(
    LPTSTR pszDest,
    size_t cbDest,
    LPCTSTR pszFormat,
     ...
);

[Dax]

In all truth wsprintf is bad practice

Code: Select all

HRESULT StringCbPrintf(
    LPTSTR pszDest,
    size_t cbDest,
    LPCTSTR pszFormat,
     ...
);

So calling the 3 other functions is cleaner?

[bone-you]

In all truth wsprintf is bad practice

Code: Select all

HRESULT StringCbPrintf(
    LPTSTR pszDest,
    size_t cbDest,
    LPCTSTR pszFormat,
     ...
);

So calling the 3 other functions is cleaner?

safer*

wsprint can lead to buffer errors as what happens with me so often with zbot receiving packets of such great unknown length or by chance an error.

That version makes sure it doesn't exceed cbDest bytes making SURE it doesn't overflow

[Dax]

In all truth wsprintf is bad practice

Code: Select all

HRESULT StringCbPrintf(
    LPTSTR pszDest,
    size_t cbDest,
    LPCTSTR pszFormat,
     ...
);

So calling the 3 other functions is cleaner?

safer*

wsprint can lead to buffer errors as what happens with me so often with zbot receiving packets of such great unknown length or by chance an error.

That version makes sure it doesn't exceed cbDest bytes making SURE it doesn't overflow

But with my use of it aslong as the buffer has enough bytes for " killed " +20 more for char names how could it overflow? That chance error you speak of?


[EDIT] Because i've never seen any error from wsprintf unless it was an overflow caused by the programmer(not chance).

[bone-you]

So calling the 3 other functions is cleaner?

safer*

wsprint can lead to buffer errors as what happens with me so often with zbot receiving packets of such great unknown length or by chance an error.

That version makes sure it doesn't exceed cbDest bytes making SURE it doesn't overflow

But with my use of it aslong as the buffer has enough bytes for " killed " +20 more for char names how could it overflow? That chance error you speak of?


[EDIT] Because i've never seen any error from wsprintf unless it was an overflow caused by the programmer(not chance).

You could use plenty of clientside edits to rape ANY hg out there if you consider the uses of wsprintf.

[Dax]

safer*

wsprint can lead to buffer errors as what happens with me so often with zbot receiving packets of such great unknown length or by chance an error.

That version makes sure it doesn't exceed cbDest bytes making SURE it doesn't overflow

But with my use of it aslong as the buffer has enough bytes for " killed " +20 more for char names how could it overflow? That chance error you speak of?


[EDIT] Because i've never seen any error from wsprintf unless it was an overflow caused by the programmer(not chance).

You could use plenty of clientside edits to rape ANY hg out there if you consider the uses of wsprintf.

Yeah you did open my eyes a lot just then. But my use still can't overflow

So in conclusion of this entire topic. I pwn you all.