Client sources bug, in walking mode

xenx · Post by **xenx** » Tue Dec 19, 2006 1:58 am

Has anyone got some clean (meaning no huge amounts of random stupid added features) 3.51 client sources, preferably with angels and crafting enabled (crafting not essential but angels are a pain in the ass)

im using the HB Lotus sources that were released a while back as they had most stuff already added, but theres a really annoying bug that i just cant seem to fix (or even identify)

the client seems especially graphically laggy, and according to the people who use it to log on to my server, when you walk on your character you seem to randomly jump 1 square sideways occasionally, its extremely annoying and its pretty much the only thing that needs fixing on mine, does anyone either have a nice clean client with cafting/angels or does anyone know what on earth this bug could be?

anyone had a look at the lotus sources?

juggalo2 · Post by **juggalo2** » Tue Dec 19, 2006 2:51 am

yea there src have most buges fixed but aslo the walk bug is in snopys client src 2 so yep best way code up ur own from 2.20

bone-you · Post by **bone-you** » Tue Dec 19, 2006 3:01 am

What walk bug? Never experienced a bug that moves you sideways randomly. SS or video?

xenx · Post by **xenx** » Tue Dec 19, 2006 3:34 am

i cant send u a screen or video cause it only happens when ur connected remotely, doesnt happen when your connected to your own server

i swapped server files over with a friend of mine to test it and i get it to

its only in walking mode, you kind of move back and across 1 square, seems to be when you change direction altough also seems to happen when u change peace/combat mode (not sure about that but thats how i remember it)

and no way am i gonna code a full client again i just added angel sprites alone trying to do that and it took forever it must be a simple error somewhere

bone- use your client to connect to someone elses server and u will see it when u walk around,

i thought (although im noob) it might be something to do with walking speed a difference between client/server perhaps

problem with that theory is that it doesnt seem like a bump in fact if you look closely your character actually seems to move for a split second from the centre of the screen. to 1 square out (random direction from what i can tell)

i dont know where to even start looking in the sources for a problem like this.

bone-you · Post by **bone-you** » Tue Dec 19, 2006 5:35 am

xenx wrote: i cant send u a screen or video cause it only happens when ur connected remotely, doesnt happen when your connected to your own server

i swapped server files over with a friend of mine to test it and i get it to

its only in walking mode, you kind of move back and across 1 square, seems to be when you change direction altough also seems to happen when u change peace/combat mode (not sure about that but thats how i remember it)

and no way am i gonna code a full client again i just added angel sprites alone trying to do that and it took forever it must be a simple error somewhere

bone- use your client to connect to someone elses server and u will see it when u walk around,

i thought (although im noob) it might be something to do with walking speed a difference between client/server perhaps

problem with that theory is that it doesnt seem like a bump in fact if you look closely your character actually seems to move for a split second from the centre of the screen. to 1 square out (random direction from what i can tell)

i dont know where to even start looking in the sources for a problem like this.

I do use my client >.> I made my own from 2.20 and it doesn't do this "walking" bug that you speak of which is why I'm asking. On 2.20 it functions fine, on 3.51 it functions fine, and on my own custom hg it functions fine.

juggalo2 · Post by **juggalo2** » Tue Dec 19, 2006 4:10 pm

the walk bug is in ur hg i have started codeing up the 2.17 srces to 3.82 and when i use the hg i dont get walk bug with any coustom client. so there for its ur hg 2.24c has it or lotus src

ADDKiD · Post by **ADDKiD** » Tue Dec 19, 2006 7:20 pm

Connected Remotely? Hell no, I get this bug when I'm connected to any server. (Minus Zero and Dax's Files, Only ones capable of coding up a 2.20). It just makes you move 1 square...

juggalo2 · Post by **juggalo2** » Tue Dec 19, 2006 8:33 pm

im doing it lol im almost doen 60% ibn 2 days

ADDKiD · Post by **ADDKiD** » Tue Dec 19, 2006 9:06 pm

What causes it to jump like that? I still don't get that. (I'm going to shit for this, I have a feeling..)

xenx · Post by **xenx** » Tue Dec 19, 2006 11:01 pm

the problem is in the HG then folks? not the client? i always thought it was a client side bug O.o

i hope its not in the HG /cry iv made so many changes i really dont wanna start again

i know this is going off topic a little bit but iv blown the dust off some other sources i have, and it has that bug where it says your hp has been decreased by (amount) whenever you move 1 square..

iv seen this before but i cant for the life of me remember what i did that caused it

what is it that causes that bug can anyone remember ?
this is HG source btw

xenx · Post by **xenx** » Wed Dec 20, 2006 2:39 am

gah, u know what, im not gonna let it bother me its an annoying bug for sure but i have my client and HG matching perfectly and all other sources i can find are full of crap that was fixed years ago,

im gonna carry on with what i got and if a fix turns up then gr8, if not, i dont care

not gonna let 1 stupid little bug ruin all my work

Jensen · Post by **Jensen** » Wed Dec 20, 2006 7:16 pm

not that im quite sure what your bug actually is here, let me take a stab at checking if its what i think it is.

say we have a 3x3 grid over here

Code: Select all

__|__|__
__|__|__
   |  |

if were walking from bottom mid to top mid and while walking you change to attack mode you seem to teleport from the middle spot to the top w/e really moving there, or do you move to something on the side.

i can give reason for the first case, not that it shouldnt be handled better, but the second one ... idk

xenx · Post by **xenx** » Thu Dec 21, 2006 10:22 pm

you mean do you always move upwards 1 sqaure?
hmm im not entirely sure, its possible that you only move upwards, i havent tested it in a while iv only been connecting to my own server so i havent seen it for a bit,

why m8 what do you think it is?

hmm i just found this right at the bottom of iClientMotion_Move_Handler right before RequestInitPlayerHandler

Code: Select all

  	DeleteClient(iClientH, TRUE, TRUE);
  	return 0;
  }
  return 0;
	}
                SendEventToNearClient_TypeA(iClientH, DEF_OWNERTYPE_PLAYER, MSGID_EVENT_MOTION, DEF_OBJECTNULLACTION, NULL, NULL, NULL);

	return 1;
}

in 2.24b sources it is

Code: Select all

  	DeleteClient(iClientH, TRUE, TRUE);
  	return 0;
  }
  return 0;
	}

	return 1;
}

why is this there in these sources ?

Code: Select all

SendEventToNearClient_TypeA(iClientH, DEF_OWNERTYPE_PLAYER, MSGID_EVENT_MOTION, DEF_OBJECTNULLACTION, NULL, NULL, NULL);

this is HG btw..

Jensen · Post by **Jensen** » Fri Dec 22, 2006 1:17 am

hmm, mine is based on the 2.24c and has the same style there as the 2.24b.

ill try it with your addition see what affects seem different here.

Jensen · Post by **Jensen** » Fri Dec 22, 2006 1:39 am

check the above two statements, that line is never executed.

at the end of the if, and the else, there is a return statement so program flow never reaches that line, unless i read that horribly wrong.